Skip to content
Success

Changes

Summary

  1. [CI-SKIP] Introduce tests to validate the unviability of Intrinsic (commit: af687e3) (details)
  2. Refractor mixin prefix generation (commit: 1df7dfb) (details)
Commit af687e3fcb2c3abca817e6b46e48fd0ef0966ff5 by Geolykt
[CI-SKIP] Introduce tests to validate the unviability of Intrinsic

We will most likely be using `@Unique` in the meantime.

From one comment of mine on sponge's discord:
Nevermind, that wouldn't work as `@Intrinisc` requires a prefix (my assumption
is that it has a hardcoded check for `$` - which is why the mixin documentation
for the prefixes is a bit fuzzy or even contradicting itself as that hardcoded
check probably wasn't intended at first but was declared WAI later on).
However, as `@Intrinsic` does not have a prefix element in of itself, it relies
on other annotations to provide the prefix. So in the end `@Intrinsic`'s only
purpose is to soft-implement an interface and what I'm looking after
(hard-implementing an interface) should be done via `@Unique`.
(commit: af687e3)
The file was modifiedmicromixin-test-j8/src/main/java/org/stianloader/micromixin/test/j8/TestHarness.java (diff)
The file was modifiedmicromixin-test-j8/src/main/java/org/stianloader/micromixin/test/j8/mixin/MixinOverwriteTestMixins.java (diff)
The file was modifiedmicromixin-test-j8/src/main/resources/j8mixinconfig.json (diff)
The file was modifiedmicromixin-test-j8/src/main/java/org/stianloader/micromixin/test/j8/targets/MixinOverwriteTest.java (diff)
The file was addedmicromixin-test-j8/src/main/java/org/stianloader/micromixin/test/j8/targets/invalid/InvalidIntrinsic.java
Commit 1df7dfbbe9ddef3e00186c28b07b9c06fcc565a7 by Geolykt
Refractor mixin prefix generation

This includes a tiny bugfix and also hides some internal
fields to avoid just using the handler prefix but not the handler counter
or not incrementing the counter - regardless, provocating this
behaviour is a bit more difficult now so that shouldn't
happen by accident.
(commit: 1df7dfb)
The file was modifiedmicromixin-transformer/src/main/java/org/stianloader/micromixin/transform/internal/HandlerContextHelper.java (diff)
The file was modifiedmicromixin-transformer/src/main/java/org/stianloader/micromixin/transform/internal/annotation/MixinInjectAnnotation.java (diff)
The file was modifiedmicromixin-transformer/src/main/java/org/stianloader/micromixin/transform/internal/annotation/MixinRedirectAnnotation.java (diff)
The file was modifiedmicromixin-transformer/src/main/java/org/stianloader/micromixin/transform/internal/MixinStub.java (diff)
The file was modifiedmicromixin-transformer/src/main/java/org/stianloader/micromixin/transform/internal/annotation/MixinModifyArgAnnotation.java (diff)
The file was modifiedmicromixin-transformer/src/main/java/org/stianloader/micromixin/transform/internal/annotation/MixinModifyConstantAnnotation.java (diff)
The file was modifiedmicromixin-transformer/src/main/java/org/stianloader/micromixin/transform/internal/annotation/mixinsextras/MixinExtrasModifyReturnValueAnnotation.java (diff)