Started by GitHub push by Geolykt31b9bdb749bdaf91ebf351f60a901f8f8419b550d5b9bdb749bdaf91ebf351f60a901f8f8419b550d5refs/remotes/origin/mainb9bdb749bdaf91ebf351f60a901f8f8419b550d5b9bdb749bdaf91ebf351f60a901f8f8419b550d5refs/remotes/origin/mainb9bdb749bdaf91ebf351f60a901f8f8419b550d5b9bdb749bdaf91ebf351f60a901f8f8419b550d5refs/remotes/origin/mainhttps://github.com/stianloader/Micromixin.githttps://stianloader.org/jenkins/view/all/job/micromixin/31/artifacthttps://stianloader.org/jenkins/view/all/job/micromixin/changeshttps://stianloader.org/jenkins/view/all/job/micromixin/31/https://stianloader.org/jenkins/view/all/job/micromixin/31/testReportfalse#313124642691micromixin #3131falsefalse31126SUCCESS1714316701979https://stianloader.org/jenkins/view/all/job/micromixin/31/micromixin-annotations/src/main/java/org/spongepowered/asm/mixin/injection/ModifyConstant.javamicromixin-test-j8/src/main/java/org/stianloader/micromixin/test/j8/targets/ArgumentCaptureTest.javamicromixin-transformer/src/main/java/org/stianloader/micromixin/transform/internal/annotation/mixinsextras/MixinExtrasModifyReturnValueAnnotation.javamicromixin-test-j8/src/main/java/org/stianloader/micromixin/test/j8/mixin/ArgumentCaptureMixins.javamicromixin-transformer/src/main/java/org/stianloader/micromixin/transform/internal/annotation/MixinModifyConstantAnnotation.javamicromixin-annotations/src/main/java/com/llamalad7/mixinextras/injector/ModifyReturnValue.javamicromixin-transformer/src/main/java/org/stianloader/micromixin/transform/internal/util/locals/ArgumentCaptureContext.javamicromixin-test-j8/src/main/java/org/stianloader/micromixin/test/j8/TestHarness.javab9bdb749bdaf91ebf351f60a901f8f8419b550d51714316369000https://stianloader.org/jenkins/user/geolyktGeolyktadmin@geolykt.deImplement argument capture in `@ModifyConstant` and `@ModifyReturnValue` I'm not sure why I thought that wasn't possible while first implementing the annotations. Regardless, this code somehow seems to work first-try, which is why tests don't crash anymore! However on the flip side of things it seems like the allow tests are a bit flawed - so I might have incorrectly implemented that annotation element. There are also two other tests that fail, but I assume that those are long-standing problems I never bothered to fix. Might be a low-hanging fruit for a potential contributor. Although I don't think those actually exist (I know you don't exist, dear reader. Don't pretend anything else). Uh where was I? Ah yes, the failures - I recall there having been one or two failures for quite a while now, so I assume that this commit doesn't produce any regressions. And on the front of the allow tests: Well I don't think it really matters whether anything regressed as the tests wouldn't even run before this commit. 2024-04-28 16:59:29 +0200b9bdb749bdaf91ebf351f60a901f8f8419b550d5Implement argument capture in `@ModifyConstant` and `@ModifyReturnValue`editmicromixin-transformer/src/main/java/org/stianloader/micromixin/transform/internal/annotation/mixinsextras/MixinExtrasModifyReturnValueAnnotation.javaeditmicromixin-annotations/src/main/java/org/spongepowered/asm/mixin/injection/ModifyConstant.javaeditmicromixin-transformer/src/main/java/org/stianloader/micromixin/transform/internal/annotation/MixinModifyConstantAnnotation.javaeditmicromixin-annotations/src/main/java/com/llamalad7/mixinextras/injector/ModifyReturnValue.javaeditmicromixin-test-j8/src/main/java/org/stianloader/micromixin/test/j8/mixin/ArgumentCaptureMixins.javaeditmicromixin-test-j8/src/main/java/org/stianloader/micromixin/test/j8/targets/ArgumentCaptureTest.javaaddmicromixin-transformer/src/main/java/org/stianloader/micromixin/transform/internal/util/locals/ArgumentCaptureContext.javaeditmicromixin-test-j8/src/main/java/org/stianloader/micromixin/test/j8/TestHarness.javagithttps://stianloader.org/jenkins/user/geolyktGeolyktgeolykt