Started by GitHub push by Geolykt30ed69fd1ea9e4c43d26e06e5d46acbb9c05365080ed69fd1ea9e4c43d26e06e5d46acbb9c0536508refs/remotes/origin/master0ed69fd1ea9e4c43d26e06e5d46acbb9c05365080ed69fd1ea9e4c43d26e06e5d46acbb9c0536508refs/remotes/origin/master0ed69fd1ea9e4c43d26e06e5d46acbb9c05365080ed69fd1ea9e4c43d26e06e5d46acbb9c0536508refs/remotes/origin/masterhttps://github.com/stianloader/Starloader.githttps://stianloader.org/jenkins/view/SLL%20variants/job/launcher-sponge/3/artifacthttps://stianloader.org/jenkins/view/SLL%20variants/job/launcher-sponge/changeshttps://stianloader.org/jenkins/view/SLL%20variants/job/launcher-sponge/3/https://stianloader.org/jenkins/view/SLL%20variants/job/launcher-sponge/3/testReportfalse#31910323452launcher-sponge #33falsefalse327SUCCESS1717509045303https://stianloader.org/jenkins/view/SLL%20variants/job/launcher-sponge/3/README.mddb0d89fc1d79b1cbba0f0deac3c71f28e218d06f1717506716000https://stianloader.org/jenkins/user/geolyktGeolyktadmin@geolykt.deCleanup readme Launcher-micromixin is where most of the fun lies in, launcher-sponge is an ancient relic of an ancient past. 2024-06-04 15:11:56 +0200db0d89fc1d79b1cbba0f0deac3c71f28e218d06fCleanup readmeeditREADME.mdpom.xmlsrc/main/java/de/geolykt/starloader/launcher/Utils.java7761948c3fc144a7ba532166ea4005b2592425be1717507035000https://stianloader.org/jenkins/user/geolyktGeolyktadmin@geolykt.deMove to org.stianloader groupid, update micromixin Now with MixinExtras - whyever you'd want to consume that. 2024-06-04 15:17:15 +02007761948c3fc144a7ba532166ea4005b2592425beMove to org.stianloader groupid, update micromixineditpom.xmleditsrc/main/java/de/geolykt/starloader/launcher/Utils.javapom.xmlc4744d99d324562f9c71870411367de6c1c2257c1717507229000https://stianloader.org/jenkins/user/geolyktGeolyktadmin@geolykt.deUpdate dependencies Also try to test out whether the CI pipeline is intact or not, it seems to be half-broken at this point. Oh well 2024-06-04 15:20:29 +0200c4744d99d324562f9c71870411367de6c1c2257cUpdate dependencieseditpom.xmlsrc/main/java/net/minestom/server/extras/selfmodification/MinestomRootClassLoader.javasrc/main/java/de/geolykt/starloader/mod/ExtensionManager.javasrc/main/java9/module-info.javasrc/main/java/de/geolykt/starloader/launcher/Utils.javasrc/main/resources/logback.xmlsrc/main/java/de/geolykt/starloader/mod/DiscoveredExtension.javapom.xmle16e53dbc870bfceb98fb063a498c41a8f77edcd1717508420000https://stianloader.org/jenkins/user/geolyktGeolyktadmin@geolykt.deGet rid of GSON GSON was previously used by sponge's mixin framework; but since micromixin is not dependent on it GSON can be removed from the micromixin variant of SLL --- Note: This commit was originally made for the launcher-micromixin variant of SLL, but in the launcher-sponge variant of SLL GSON is still needed as a transitive dependency of micromixin. It will thus continue to be present at runtime within launcher-sponge (but not launcher-micromixin!!). This cherry-pick also includes the extension loading hotfix commit b122c6a26654aa69f27e3709cf82023ea1f0105e - but it surprises me that everything works as it should in this environment if I'll be completely honest. 2024-06-04 15:40:20 +0200e16e53dbc870bfceb98fb063a498c41a8f77edcdGet rid of GSONeditsrc/main/java/de/geolykt/starloader/launcher/Utils.javaeditsrc/main/java/net/minestom/server/extras/selfmodification/MinestomRootClassLoader.javaeditsrc/main/java/de/geolykt/starloader/mod/DiscoveredExtension.javaeditpom.xmleditsrc/main/java/de/geolykt/starloader/mod/ExtensionManager.javaeditsrc/main/resources/logback.xmleditsrc/main/java9/module-info.javasrc/main/java/de/geolykt/starloader/util/LogFileAppender.javasrc/main/resources/logback.xml54f060af6b1cb0e2b5c687330c0829ff3b0d557b1717508545000https://stianloader.org/jenkins/user/geolyktGeolyktadmin@geolykt.deImprovements to the logging facilities 2024-06-04 15:42:25 +020054f060af6b1cb0e2b5c687330c0829ff3b0d557bImprovements to the logging facilitieseditsrc/main/java/de/geolykt/starloader/util/LogFileAppender.javaeditsrc/main/resources/logback.xmlsrc/main/java/net/minestom/server/extras/selfmodification/MinestomExtensionClassLoader.javasrc/main/java/net/minestom/server/extras/selfmodification/MinestomRootClassLoader.javae7ccf2b3c233e3e6885dc30fcdc852b6834ff9301717508592000https://stianloader.org/jenkins/user/geolyktGeolyktadmin@geolykt.deForbid extension classloaders from being able to load protected classes This is especially a problem when extension classes interact with classes loaded by other classloaders. In our case this was a problem that was experienced when having ASM as a (transitive) dependency of a mod. 2024-06-04 15:43:12 +0200e7ccf2b3c233e3e6885dc30fcdc852b6834ff930Forbid extension classloaders from being able to load protected classeseditsrc/main/java/net/minestom/server/extras/selfmodification/MinestomRootClassLoader.javaeditsrc/main/java/net/minestom/server/extras/selfmodification/MinestomExtensionClassLoader.javasrc/main/java/de/geolykt/starloader/mod/ExtensionManager.javasrc/main/java9/module-info.javasrc/main/java/de/geolykt/starloader/Starloader.javasrc/main/java/de/geolykt/starloader/mod/DiscoveredExtension.javasrc/main/java/de/geolykt/starloader/util/MirroringURIMavenRepository.javapom.xmlsrc/main/java/net/minestom/server/extras/selfmodification/MinestomExtensionClassLoader.java0ed69fd1ea9e4c43d26e06e5d46acbb9c05365081717509009000https://stianloader.org/jenkins/user/geolyktGeolyktadmin@geolykt.deAllow the resolution of external dependencies 2024-06-04 15:50:09 +02000ed69fd1ea9e4c43d26e06e5d46acbb9c0536508Allow the resolution of external dependencieseditpom.xmleditsrc/main/java/de/geolykt/starloader/Starloader.javaeditsrc/main/java/de/geolykt/starloader/mod/ExtensionManager.javaeditsrc/main/java9/module-info.javaeditsrc/main/java/net/minestom/server/extras/selfmodification/MinestomExtensionClassLoader.javaaddsrc/main/java/de/geolykt/starloader/util/MirroringURIMavenRepository.javaeditsrc/main/java/de/geolykt/starloader/mod/DiscoveredExtension.javagithttps://stianloader.org/jenkins/user/geolyktGeolyktgeolykt